Skip to content

Conversation

@MorrisJobke
Copy link
Member

No description provided.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added the enhancement New feature or request label Feb 12, 2018
@MorrisJobke MorrisJobke requested a review from Henni February 12, 2018 16:37
@jancborchardt jancborchardt requested a review from camilasan April 12, 2018 17:57
@jancborchardt
Copy link
Member

@MorrisJobke is it because they are incomplete, or because the translations are elsewhere anyway?

@MorrisJobke
Copy link
Member Author

@MorrisJobke is it because they are incomplete, or because the translations are elsewhere anyway?

We don't use the php format anymore. Those are really unused. We use json files for the server side translations and js files for client side translations.

@jancborchardt
Copy link
Member

So @Henni @korelstar @camilasan @stefan-niedermann can you review? :)

Copy link
Member

@stefan-niedermann stefan-niedermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay from my side 👍

@korelstar korelstar merged commit ce6b85b into master Apr 17, 2018
@korelstar korelstar deleted the remove-old-files branch April 17, 2018 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants