Skip to content

Conversation

@Henni
Copy link
Member

@Henni Henni commented Dec 15, 2016

No description provided.

@Henni Henni force-pushed the drone-ci branch 2 times, most recently from 17b475f to ee0bdd9 Compare December 15, 2016 00:24
@korelstar
Copy link
Member

Do you plan to replace Travis by Drone? Or should Drone be used in addition to Travis? (Would this make sense?)
This would be interesting for #35 in order to avoid to do obsolete work.

@Henni
Copy link
Member Author

Henni commented Dec 29, 2016

@korelstar yeah. It would be great if we could use Drone CI instead of Travis. (Nextcloud power 💪)
But I'd like to integrate your changes (like info.xml validation)

Additionally I currently have no idea why drone fails on this specific error. I believe this is an error that actually exists but wasn't caught by travis for some obscure reason.
@korelstar maybe you have an idea!?

@korelstar korelstar mentioned this pull request Dec 30, 2016
2 tasks
@korelstar
Copy link
Member

On the first view, I do not understand this neither, but I'm not familiar with Drone and phpunit.

@Henni
Copy link
Member Author

Henni commented Jan 13, 2017

rebased to current master (v.2.2.0)

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@jancborchardt
Copy link
Member

@korelstar @Henni any update on this one (and #52)? @camilasan @MorrisJobke can you help?

@jancborchardt jancborchardt added enhancement New feature or request help wanted Complex issue or we don't know how to fix it labels Apr 12, 2018
@korelstar
Copy link
Member

No, I still have no experiences with Drone. Some help would be great :-)

@MorrisJobke
Copy link
Member

No, I still have no experiences with Drone. Some help would be great :-)

Okay - I can help. Could you rebase and also I would say, that we should do this step by step and not all in one to keep the overview.

@jancborchardt
Copy link
Member

@MorrisJobke this seems rebased? (Has no conflicts with master)

@jancborchardt jancborchardt added this to the 2.4.0 – 🐛 Detail fixes milestone Jun 6, 2018
@MorrisJobke
Copy link
Member

Could you rebase again and then ping me? So I get a notification. Sorry for missing it last time.

@jancborchardt
Copy link
Member

@Henni @korelstar @camilasan does someone of you more technically inclined folks mind rebasing this? :)

@korelstar
Copy link
Member

@jancborchardt
This PR was created by @Henni and I have absolutely no knowledge of Drone. Therefore, I have not an exactly idea of how to solve the current conflict (tests/integration/controller/NotesApiControllerTest.php).

Would be nice if @Henni could continue on this.

@korelstar
Copy link
Member

Closing, since we have no progress for a very long time and the code is outdated in the meanwhile.

@korelstar korelstar closed this Nov 11, 2018
@jancborchardt jancborchardt deleted the drone-ci branch December 21, 2018 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request help wanted Complex issue or we don't know how to fix it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants