Skip to content

Conversation

@korelstar
Copy link
Member

@korelstar korelstar commented Dec 25, 2019

fixes #410; uses checkbox design as used in tasks app (see nextcloud/tasks#572)

Before

. Nextcloud 15 Nextcloud 18 beta 3
Windows 10 1909 Screenshot Screenshot
Debian 10 with Gnome Screenshot Screenshot

After

. Nextcloud 15 Nextcloud 18 beta 3
Windows 10 1909 Screenshot Screenshot
Debian 10 with Gnome Screenshot Screenshot

@korelstar korelstar added the feature: EasyMDE Realted to the integrated EasyMDE editor label Dec 25, 2019
@korelstar korelstar added this to the 3.1.1 milestone Dec 25, 2019
@korelstar korelstar merged commit 051c518 into master Dec 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-checkmark branch December 29, 2019 10:41
@jancborchardt
Copy link
Member

jancborchardt commented Dec 29, 2019

Sorry I only saw this now – is there a specific reason we don't use the core checkbox style like in settings and elsewhere?

We should do the same in Tasks too cc @raimund-schluessler @nextcloud/designers

@korelstar
Copy link
Member Author

The only difference is the color. The reason why tasks doesn't use the primary color is that the meaning of the checkmark is different:

  • Settings: checkmark means active = primary color.
  • Tasks and notes: checkmark means done = other color is better.

@jancborchardt
Copy link
Member

Ah ok, so the blue in the screenshot was just the emoji checkbox then? :)

And right, I remember we had the discussion in Tasks – makes sense and doesn't make the checkboxes so present. Ok! :)

@korelstar
Copy link
Member Author

Yep, the text "Checkbox: ☑ und ☐" is unicode only. The change is only the checkbox on the left side.

@jancborchardt
Copy link
Member

Hmmm, testing again and comparing also with e.g. iOS Notes it seems better to color it:

  • it's more clear what is checked and what not
  • motivates to check off unchecked items cause the colorless ones are boring
  • we really could do with a bit more color in Nextcloud as stuff is quite bland :)

cc @nextcloud/designers and especially @ma12-co regarding Notes :)

@korelstar korelstar mentioned this pull request Jan 2, 2020
@korelstar
Copy link
Member Author

Okay, In #427, I changed the design to blue. It's now the design like in Nextcloud Text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: EasyMDE Realted to the integrated EasyMDE editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Checked Checkbox is too big

3 participants