Skip to content

maintenance: CI tests, code quality #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
korelstar merged 5 commits into from
May 19, 2020
Merged

maintenance: CI tests, code quality #516

korelstar merged 5 commits into from
May 19, 2020

Conversation

@korelstar
Copy link
Member

@korelstar korelstar commented May 18, 2020 •
edited
Loading

  • allow max-nc-version to be higher than server git
  • increase Nextcloud max-version to 21 (for testing and to be ready for future)
  • run API tests with both Nextcloud min-/max-version
  • set strict types in remaining PHP files
  • use JSONResponse and remove If-None-Match check (since it's in server)

@korelstar korelstar added the maintenance Software maintenance, e.g. refactoring, improve code quality, documentation etc. label May 18, 2020
@korelstar korelstar added this to the 4.0.0 milestone May 18, 2020
@korelstar korelstar force-pushed the ci-tests branch 3 times, most recently from 9d89676 to 0e3162d Compare May 18, 2020 19:05
@korelstar korelstar modified the milestones: 4.0.0, 3.4.0 May 18, 2020
@korelstar korelstar changed the title maintenance: enhance CI tests maintenance: CI tests, code quality May 19, 2020
@korelstar korelstar marked this pull request as ready for review May 19, 2020 12:40
@korelstar korelstar merged commit 66a6e8f into master May 19, 2020
@korelstar korelstar deleted the ci-tests branch May 19, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

maintenance Software maintenance, e.g. refactoring, improve code quality, documentation etc.

Projects

None yet

Milestone

3.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@korelstar