Skip to content

Conversation

@korelstar
Copy link
Member

fix #524

@korelstar korelstar added bug Something isn't working maintenance Software maintenance, e.g. refactoring, improve code quality, documentation etc. labels May 31, 2020
@korelstar korelstar added this to the 3.5.0 milestone May 31, 2020
@korelstar korelstar requested a review from jancborchardt May 31, 2020 09:44
@jancborchardt
Copy link
Member

Seems to still work, but I’m actually getting different errors creating notes – possibly unrelated?

"Creating new note has failed. See JavaScript console and server log for details"

Server log:

[notes] Error: OCP\Files\NotPermittedException: Could not create path at <<closure>>

 0. /home/jan/nextcloud/apps/notes/lib/Service/NotesService.php line 63
    OC\Files\Node\Folder->newFile("New note.txt")
 1. /home/jan/nextcloud/apps/notes/lib/Controller/NotesController.php line 122
    OCA\Notes\Service\NotesService->create("jan", "", "")
 2. /home/jan/nextcloud/apps/notes/lib/Controller/Helper.php line 28
    OCA\Notes\Controller\NotesController->OCA\Notes\Controller\{closure}("*** sensitive parameters replaced ***")
 3. /home/jan/nextcloud/apps/notes/lib/Controller/NotesController.php line 125
    OCA\Notes\Controller\Helper->handleErrorResponse(Closure {})
 4. /home/jan/nextcloud/lib/private/AppFramework/Http/Dispatcher.php line 169
    OCA\Notes\Controller\NotesController->create("")
 5. /home/jan/nextcloud/lib/private/AppFramework/Http/Dispatcher.php line 100
    OC\AppFramework\Http\Dispatcher->executeController(OCA\Notes\Controller\NotesController {}, "create")
 6. /home/jan/nextcloud/lib/private/AppFramework/App.php line 137
    OC\AppFramework\Http\Dispatcher->dispatch(OCA\Notes\Controller\NotesController {}, "create")
 7. /home/jan/nextcloud/lib/private/AppFramework/Routing/RouteActionHandler.php line 47
    OC\AppFramework\App::main("OCA\\Notes\\Controller\\NotesController", "create", OC\AppFramework\ ... {}, {_route: "notes.notes.create"})
 8. <<closure>>
    OC\AppFramework\Routing\RouteActionHandler->__invoke({_route: "notes.notes.create"})
 9. /home/jan/nextcloud/lib/private/Route/Router.php line 297
    call_user_func(OC\AppFramework\ ... {}, {_route: "notes.notes.create"})
10. /home/jan/nextcloud/lib/base.php line 1008
    OC\Route\Router->match("/apps/notes/notes")
11. /home/jan/nextcloud/index.php line 37
    OC::handleRequest()

POST /nextcloud/index.php/apps/notes/notes
from 127.0.0.1 by jan at 2020-06-01T00:27:50+00:00

@korelstar
Copy link
Member Author

Hmm. Indeed, that issue sounds unrelated. However, I would like to analysis it in more detail.

Does this also happen when using master branch? Are you able to create a file in your notes directory using the files app?

@jancborchardt jancborchardt merged commit 937f0eb into master Jun 1, 2020
@jancborchardt jancborchardt deleted the application branch June 1, 2020 13:54
@jancborchardt
Copy link
Member

Merging this for now – I’ll investigate more regarding the issue as I can reproduce on master. :)

@jancborchardt
Copy link
Member

I did a full uninstall, removed the "Notes" folder, installed it again, now it works. Thanks for the hint on the Notes folder via Files. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working maintenance Software maintenance, e.g. refactoring, improve code quality, documentation etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RuntimeException: App class OCA\Notes\Application is not setup via query() but directly

3 participants