Front/webpush by p1gp1g · Pull Request #2663 · nextcloud/notifications

p1gp1g · 2025-11-28T08:54:32Z

This PR uses the new web push support (#2662) to get push notifications on the web application, even when nextcloud isn't opened in the browser.

It achieves 2 things:

it gives push notifications when nextcloud isn't opened: this is particularly useful for collaborative work, as nexcloud isn't always opened but we can expect to be notified anyway. (I won't miss call, polls, or events anymore)
it gives real time notifications, without the notify_push app (which adds a websocket support to nextcloud). It should reduce load on the server as the periodic fetch is reduce to once every 15min. When the server get a notification for a user, it sends it to the user through its push server (all modern browser are connected to a push server)

To work, this PR needs to add worker-src 'self' to the CSP by default:

https://github.com/nextcloud/server/blob/master/lib/public/AppFramework/Http/EmptyContentSecurityPolicy.php#L62

-	protected $allowedWorkerSrcDomains = null;
+	protected $allowedWorkerSrcDomains = ["'self'"];

github-actions · 2025-12-13T02:30:36Z

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

p1gp1g · 2026-02-12T11:21:14Z

I've rebased the PR on the master branch, and updated following some changes we did: apptype (array) => appTypes (String)

Elsensee · 2026-02-12T18:12:04Z

I really love this PR and I wanted WebPush support in Nextcloud for some time already, so I am super sorry for all this!

But another thing I noticed was, that you don’t seem to handle delete notifications at all? I am not even sure, how this could be properly handled. You could call getNotifications() and then close() but on Android this might still appear in the notification history. Also, when the tab is closed you must show a notification on push.
Alternatively, you could replace the notification with some silent notification with title "This notification has been deleted" and then quickly close() it, but I don’t know if that will actually work.

I assume, integrating UnifiedPush for the mobile apps will be a lot more straight forward as most logic should already be in place there. It’s just a shame, that you have to do all this manual legwork for browsers. 😅

p1gp1g · 2026-02-12T19:05:42Z

I suppose this is a typo and you're not sorry for this ?

BTW, your help is very welcome, thanks. I will show a generic notification if we don't have the right content. You can also suggest code directly or open PR on my repo if you want :)

Regarding UnifiedPush: the implementation is already done, I've a few things to do following changes on the backend Pr :D

Elsensee · 2026-02-12T19:48:40Z

I just didn't want to come across as rude and complaining about a lot, especially since I am not affiliated with Nextcloud. :)

And nice, I will see what my time allows me to do on contributing. :)

I’m looking forward to the UnifiedPush implementation!

p1gp1g · 2026-02-12T20:18:03Z

No problem, code review is done for that ! At the end we have a better solution

Antreesy

From my POV frontend changes look fine. We tried it on a test instance, looks like working =)

regarding putting i file in /public and then having it on a root - if it's not an issue to have it on master branch, I can address it in a follow-up, it's not really related to webpush to block this PR from merging

nickvergessen

Otherwise good to go from API side

nickvergessen · 2026-03-27T08:35:08Z

 	}
+
+	/**
+	 * @return Int tokenId from IToken or ISession, negative in case of Session id, positive otherwise


I'm a bit scare about this part.
I think I'd prefer having a second db field instead

nickvergessen · 2026-03-27T08:35:32Z

 	protected function validateToken(int $tokenId, int $maxAge): TokenValidation {
+		// This is a web session token
+		if ($tokenId < 0) {
+			return TokenValidation::VALID;


Why is it okay for a web session to be always valid?

They are Session and not Token, and $this->tokenProvider->getTokenById($tokenId) doesn't work for the session.

The idea is if the web push registration is removed from the browser, or expire because the user doesn't use their browser for some time, the push server will respond with 404 or 410, and the token will be wiped at this moment

Antreesy

LGTM, pls maybe rebase and squash it up to 1-3 commits. Also double check DCO and other CI failures - NPM build we can trigger later separately

Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: S1m <31284753+p1gp1g@users.noreply.github.com>

…eWorker Signed-off-by: sim <git@sgougeon.fr>

Signed-off-by: sim <git@sgougeon.fr>

Signed-off-by: Joas Schilling <coding@schilljs.com>

Signed-off-by: sim <git@sgougeon.fr>

Co-authored-by: Maksim Sukharev <antreesy.web@gmail.com> Signed-off-by: S1m <31284753+p1gp1g@users.noreply.github.com>

Signed-off-by: Joas Schilling <coding@schilljs.com>

Signed-off-by: Joas Schilling <coding@schilljs.com> Signed-off-by: sim <git@sgougeon.fr>

Signed-off-by: sim <git@sgougeon.fr>

Co-authored-by: Maksim Sukharev <antreesy.web@gmail.com> Signed-off-by: S1m <31284753+p1gp1g@users.noreply.github.com> Signed-off-by: sim <git@sgougeon.fr>

p1gp1g · 2026-03-27T11:51:55Z

Sorry, I missed another unconventional commit

nickvergessen · 2026-03-27T13:02:50Z

Will send a recompile PR afterwards

p1gp1g requested a review from nickvergessen as a code owner November 28, 2025 08:54

p1gp1g mentioned this pull request Nov 28, 2025

WebPush support #1225

Closed

This comment was marked as resolved.

Sign in to view

p1gp1g force-pushed the front/webpush branch 2 times, most recently from b74d5a6 to 4456cb0 Compare November 28, 2025 10:51

nickvergessen added enhancement 2. developing feature: push 📲 feature: frontend 🖌️ labels Dec 2, 2025

nickvergessen added this to the Nextcloud 33 milestone Dec 2, 2025

p1gp1g force-pushed the front/webpush branch from 4456cb0 to f029393 Compare December 2, 2025 09:09

nickvergessen marked this pull request as draft December 2, 2025 09:48

This comment was marked as resolved.

Sign in to view

github-actions Bot added the feedback-requested label Dec 13, 2025

p1gp1g force-pushed the front/webpush branch from f029393 to 3b9f200 Compare February 12, 2026 11:18

p1gp1g marked this pull request as ready for review February 12, 2026 11:20

p1gp1g force-pushed the front/webpush branch from 3b9f200 to ec63ade Compare February 12, 2026 12:39

Elsensee reviewed Feb 12, 2026

View reviewed changes

Comment thread src/NotificationsApp.vue Outdated

Comment thread src/NotificationsApp.vue Outdated

Elsensee reviewed Feb 12, 2026

View reviewed changes

Comment thread src/NotificationsApp.vue

p1gp1g commented Feb 13, 2026

View reviewed changes

Comment thread public/service-worker.js

p1gp1g force-pushed the front/webpush branch from 5e1deb0 to cb3b999 Compare February 16, 2026 13:35

nextcloud-bot mentioned this pull request Feb 16, 2026

[stable33] 33.0.0 nextcloud/server#58364

Merged

blizzz modified the milestones: Nextcloud 33, Nextcloud 34 Feb 16, 2026

Antreesy reviewed Mar 18, 2026

View reviewed changes

Comment thread src/services/webPushService.js Outdated

nickvergessen mentioned this pull request Mar 24, 2026

NextPush/UnifiedPush nextcloud/spreed#17480

Closed

nickvergessen approved these changes Mar 27, 2026

View reviewed changes

Antreesy approved these changes Mar 27, 2026

View reviewed changes

Comment thread src/services/webPushService.js Outdated

p1gp1g force-pushed the front/webpush branch 3 times, most recently from 1239274 to 089b7cc Compare March 27, 2026 10:51

p1gp1g and others added 17 commits March 27, 2026 12:51

feat(webpush): Update lib/Controller/WebController.php

8e5b682

Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: S1m <31284753+p1gp1g@users.noreply.github.com>

feat(webpush): Call callback(false) if browser doesn't support servic…

c363167

…eWorker Signed-off-by: sim <git@sgougeon.fr>

feat(webpush): Use full name for arguments

65a6cec

Signed-off-by: sim <git@sgougeon.fr>

feat(webpush): Keep requestWebNotificationPermissions async

892c812

Signed-off-by: sim <git@sgougeon.fr>

feat(webpush): Move web push function to dedicated service file

b2f6419

Signed-off-by: sim <git@sgougeon.fr>

fix: Add missing class imports

978fbaa

Signed-off-by: Joas Schilling <coding@schilljs.com>

feat(webpush): Use better secure context check

1349bc8

Signed-off-by: sim <git@sgougeon.fr>

feat(webpush): Lint debugging line

5229fdc

Signed-off-by: sim <git@sgougeon.fr>

feat(webpush): Always catch when browser need userVisibleOnly

65a40b4

Signed-off-by: sim <git@sgougeon.fr>

feat(webpush): Avoid redundant code to set web push

f678e0d

Signed-off-by: sim <git@sgougeon.fr>

feat(webpush): Use web push dedicated function to fetch notifications

b5df1c3

Signed-off-by: sim <git@sgougeon.fr>

feat(webpush): Add SPDX header

ac30f7f

Signed-off-by: sim <git@sgougeon.fr>

fix(webpush): Fix hasNotifyPush check

dcb0aee

Co-authored-by: Maksim Sukharev <antreesy.web@gmail.com> Signed-off-by: S1m <31284753+p1gp1g@users.noreply.github.com>

chore(assets): Recompile assets

09fd659

Signed-off-by: Joas Schilling <coding@schilljs.com>

fix(webpush): Fix psalm in WebController

3a5954d

Signed-off-by: Joas Schilling <coding@schilljs.com> Signed-off-by: sim <git@sgougeon.fr>

feat(webpush): Use getRoot to get service worker scope

3e0d077

Signed-off-by: sim <git@sgougeon.fr>

feat(webpush): Apply suggestion from @Antreesy

3451d2e

Co-authored-by: Maksim Sukharev <antreesy.web@gmail.com> Signed-off-by: S1m <31284753+p1gp1g@users.noreply.github.com> Signed-off-by: sim <git@sgougeon.fr>

p1gp1g force-pushed the front/webpush branch from 089b7cc to 3451d2e Compare March 27, 2026 11:51

nickvergessen merged commit 95750ce into nextcloud:master Mar 27, 2026
45 of 47 checks passed

nickvergessen mentioned this pull request Mar 27, 2026

chore(assets): Recompile assets #2877

Merged

This comment was marked as spam.

Sign in to view

Conversation

p1gp1g commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

github-actions Bot commented Dec 13, 2025

Uh oh!

p1gp1g commented Feb 12, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Elsensee commented Feb 12, 2026

Uh oh!

p1gp1g commented Feb 12, 2026

Uh oh!

Elsensee commented Feb 12, 2026

Uh oh!

p1gp1g commented Feb 12, 2026

Uh oh!

Uh oh!

Antreesy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nickvergessen left a comment

Choose a reason for hiding this comment

Uh oh!

nickvergessen Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

nickvergessen Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

p1gp1g Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Antreesy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

p1gp1g commented Mar 27, 2026

Uh oh!

Uh oh!

nickvergessen commented Mar 27, 2026

Uh oh!

This comment was marked as spam.

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

p1gp1g commented Nov 28, 2025 •

edited

Loading