[stable33] fix: Add missing DI for IAppConfig to Push.php#3039
Merged
Conversation
Contributor
SystemKeeper
commented
May 29, 2026
SystemKeeper
commented
- Regression from [stable33] feat(push): Optionally use OAEP padding #2986 / feat(push): Optionally use OAEP padding #2971
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Contributor
Author
|
/backport to stable32 |
github-actions
Bot
changed the title
SystemKeeper
force-pushed
the
add-missing-di-for-push
branch
from
693bc36 to
ef7f5fb
Compare
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
SystemKeeper
force-pushed
the
add-missing-di-for-push
branch
from
ef7f5fb to
c66c3cd
Compare
Contributor
Author
|
User confirming: #3035 (comment) |
miaulalala
approved these changes
May 29, 2026
|
How was the (unit) test not failing before? This should have triggered a failing tests at the very least. Yes I see the unit test is updated now. But not with a new test. So this could happen again in the future? Otherwise the existing tests should have triggered the issue already in the past. |
Contributor
Author
No, nothing was updated (well, the new dependency was added, but that is not an update of the test). This was a hotfix to get everything to work again on the instances, any further improvement will follow. This should have been caught by Psalm as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.