fix: Adjust to API change of "getDavPermissions" in Nextcloud 34#3475
Draft
fix: Adjust to API change of "getDavPermissions" in Nextcloud 34#3475
Conversation
Since Nextcloud 34 "DavUtil::getDavPermissions" requires the parent of the node as its second parameter. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
artonge
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Nextcloud 34
DavUtil::getDavPermissionsrequires the parent of the node as its second parameter.As this is an API breaking change in the backport to Nextcloud 33 the second parameter was made optional. It is unclear yet whether this will be applied too in Nextcloud 34 (in which case this pull request would be unneeded) or not 🤔