chore: Move tools to vendor-bin, add cs-fixer and psalm#1271
Conversation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
|
I may try to add rector but in another PR. |
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "require-dev": { | |||
| "vimeo/psalm": "^6.15" | |||
There was a problem hiding this comment.
Maybe use PHPStan from the start?
There was a problem hiding this comment.
Hmm, I’m not familiar with PHPStan yet.
There is no template in https://github.com/nextcloud/.github/tree/master/workflow-templates for it.
There was a problem hiding this comment.
See https://github.com/nextcloud/groupfolders/pull/4344/changes#diff-73a1d6ddd0eabb7e1349cdb83b76ff10f29f9e4fe316c0cd29495174181f4546. It's almost the same, only slight changes (and requires icewind1991/nextcloud-version-matrix v1.3.2)
There was a problem hiding this comment.
Maybe move that to the templates?
There was a problem hiding this comment.
I'll do that once it is merged.
There was a problem hiding this comment.
I spent enough time on this already, merging as-is.
I’m okay with migrating apps to phpstan but ideally it should be planned and done in batch.
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com> Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
4 participants
Move tools to vendor-bin
Install psalm
Install cs-fixer
Add workflow for those
Run the fixers