Migrate to Vue 3, Vite, Composition API, and updated @nextcloud/* packages#1278
Merged
Migrate to Vue 3, Vite, Composition API, and updated @nextcloud/* packages#1278
Conversation
Copilot stopped work on behalf of
skjnldsv due to an error
March 19, 2026 08:39
Copilot
AI
changed the title
[WIP] Migrate app to Vue 3 and use vite-config
Migrate to Vue 3, Vite, Composition API, and updated @nextcloud/* packages
Mar 19, 2026
2f4cd68 to
6124f41
Compare
6124f41 to
7c8a6e0
Compare
skjnldsv
approved these changes
Mar 19, 2026
eb10f72 to
f277eaf
Compare
Member
|
/compile amend |
f277eaf to
cd5965e
Compare
Member
|
@copilot fix psalm, eslint and reuse please |
susnux
reviewed
Mar 19, 2026
susnux
reviewed
Mar 19, 2026
susnux
reviewed
Mar 19, 2026
Contributor
Author
Fixed in commit
|
susnux
previously approved these changes
Mar 19, 2026
Contributor
|
overall good, some comments |
Copilot stopped work on behalf of
skjnldsv due to an error
March 19, 2026 15:55
9bf4315 to
4fec982
Compare
Member
|
@copilot fix psalm |
Contributor
Author
Fixed in commit |
632c379 to
b2713c7
Compare
Copilot
AI
changed the title
Migrate to Vue 3, Vite, Composition API, and updated @nextcloud/* packages
Fix psalm CI: replace baseline suppression with inline @psalm-suppress and fix return type
Mar 19, 2026
Member
|
/compile amend |
24a98f8 to
0e31fc2
Compare
…Composition API Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com>
… update psalm baseline Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
…e fix Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
0e31fc2 to
f174930
Compare
32 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Psalm CI was failing with 10 errors due to a mix of a real return type mismatch and unavoidable references to classes from optional external apps (
OCA\Theming,OCA\Encryption) not present in OCP stubs. The previous approach of using a baseline file was using an incorrect format for psalm 6.x, so suppressions weren't taking effect.Changes
PersonalController– FixMoreSpecificReturnType/LessSpecificReturnStatement:fetchAll()returnslist<array<string, mixed>>, not the declaredarray<int, array{id: int, displayname: string}>MissionSettings/WhoHasAccessSettings– Add inline@psalm-suppress UndefinedClassforThemingDefaults(optional theming app) and@psalm-suppress UndefinedDocblockClass, UndefinedClassforOCA\Encryption\Util(optional encryption app)psalm-baseline.xml– Clear all entries; all issues are now handled at the call site via inline suppressions, avoiding future baseline format drift💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.