Open
Conversation
It is used since Nextcloud 33, so we need to update it here. Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
Now that files v4 is being used, we need to update the code to use the v4 API to properly register the header. Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
skjnldsv
approved these changes
Apr 29, 2026
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On stable33, the header was still not registering correctly. Turns out, server is using files v4 but the app is not, so the registration is not technically wrong from the app's perspective, but it never gets registered because the server is using the newer API and does not see the app's registration.
That said, files needs to be updated to v4 on this branch too, as well as the header registration updated.
This allows the header to work properly on 33 after testing. It is related to #1023