perf: Replace getById call with getFirstNodeById#981
Merged
CarlSchwan merged 2 commits intomasterfrom Feb 5, 2026
Merged
Conversation
CarlSchwan
force-pushed
the
carl/perf-getbyid
branch
from
918246c to
d0f1352
Compare
artonge
approved these changes
Feb 5, 2026
We only use the first node anyway and using getFirstNodeById is faster. Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/perf-getbyid
branch
2 times, most recently
from
8798a81 to
d8093cf
Compare
Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/perf-getbyid
branch
from
d8093cf to
05f2383
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We only use the first node anyway and using getFirstNodeById is faster.