Files in external storage do not open correctly in Nextcloud Office

[rigg77]

Steps to reproduce

1. Place any MS Office or ODF file in an external storage folder
2. Open said file in Nextcloud Office/Collabora

Expected behavior

.ODS and .ODP should open in their respective web apps.

Actual behavior

All ODF and MS Office files open in the default editor, treating them as .ODT text files.

Host OS

Ubuntu 22.04

Nextcloud AIO version

25.0.5

Current channel

Latest

Other valuable info

[juliusknorr]

Please provide more details on what type of external storage and its auth mechanism is used and also if server side encryption is enabled

[rigg77]

SMB with global credentials and local storage no authentication.

Yes, server-side encryption is enabled, default encryption module.

[Vachha]

I have this issue as well.

Operating System: openSUSE Leap 15.4
Kernel: Linux 5.14.21-150400.24.55-default
Server version: Apache/2.4.51
PHP 8.0.28
Using php-fpm

Nextcloud V 26.0.1

• richdocuments: 8.0.1
• richdocumentscode: 22.5.1301
• Server side encryption not enabled
• Personal External storage SMB/CIFS using user's global credentials

Error log:

{"reqId":"ipGWqo7Wxaznscu3Izf1","level":3,"time":"2023-04-27T04:19:02+00:00","remoteAddr":"192.168.xxx.xxx","user":"xxx","app":"PHP","method":"GET","url":"/apps/richdocuments/index?fileId=1277147&requesttoken=cSQMxuY6Qn6VBEbHM3SmrsyVNg7OoxkBQL5KYYIY4dk%3D%3ASUxDtr94AUfYKy2iZyCR%2FvXsUnqn5HVqMPgkGfpUpKo%3D&path=%2FAJVCoFS%2FAJVCoFS-Data%2FMisc%2FCall%20forwarding%20of%20phones%20for%20Jackie%20when%20travelling.odt","message":"Undefined array key 0 at /srv/www/htdocs/nextcloud/apps/richdocuments/lib/TokenManager.php#173","userAgent":"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/112.0.0.0 Safari/537.36","version":"26.0.1.1","data":{"app":"PHP"},"id":"6449f7c2cfba0"}

{"reqId":"ipGWqo7Wxaznscu3Izf1","level":3,"time":"2023-04-27T04:19:02+00:00","remoteAddr":"192.168.xxx.xxx","user":"xxx","app":"index","method":"GET","url":"/apps/richdocuments/index?fileId=1277147&requesttoken=cSQMxuY6Qn6VBEbHM3SmrsyVNg7OoxkBQL5KYYIY4dk%3D%3ASUxDtr94AUfYKy2iZyCR%2FvXsUnqn5HVqMPgkGfpUpKo%3D&path=%2FAJVCoFS%2FAJVCoFS-Data%2FMisc%2Fxxx%20xxx%20of%20xxx%20for%20xxx%20xxx%20xxx.odt","message":"Call to a member function getOwner() on null in file '/srv/www/htdocs/nextcloud/apps/richdocuments/lib/TokenManager.php' line 176","userAgent":"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/112.0.0.0 Safari/537.36","version":"26.0.1.1","exception":{"Exception":"Exception","Message":"Call to a member function getOwner() on null in file '/srv/www/htdocs/nextcloud/apps/richdocuments/lib/TokenManager.php' line 176","Code":0,"Trace":[{"file":"/srv/www/htdocs/nextcloud/lib/private/AppFramework/App.php","line":183,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[["OCA\\Richdocuments\\Controller\\DocumentController"],"index"]},{"file":"/srv/www/htdocs/nextcloud/lib/private/Route/Router.php","line":315,"function":"main","class":"OC\\AppFramework\\App","type":"::","args":["OCA\\Richdocuments\\Controller\\DocumentController","index",["OC\\AppFramework\\DependencyInjection\\DIContainer"],["richdocuments.document.index"]]},{"file":"/srv/www/htdocs/nextcloud/lib/base.php","line":1056,"function":"match","class":"OC\\Route\\Router","type":"->","args":["/apps/richdocuments/index"]},{"file":"/srv/www/htdocs/nextcloud/index.php","line":36,"function":"handleRequest","class":"OC","type":"::","args":[]}],"File":"/srv/www/htdocs/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","Line":169,"Previous":{"Exception":"Error","Message":"Call to a member function getOwner() on null","Code":0,"Trace":[{"file":"/srv/www/htdocs/nextcloud/apps/richdocuments/lib/Controller/DocumentController.php","line":172,"function":"getToken","class":"OCA\\Richdocuments\\TokenManager","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/srv/www/htdocs/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":230,"function":"index","class":"OCA\\Richdocuments\\Controller\\DocumentController","type":"->","args":["*** sensitive parameters replaced ***","/AJVCoFS/AJVCoFS-Data/Misc/Call forwarding of phones for Jackie when travelling.odt"]},{"file":"/srv/www/htdocs/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":137,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[["OCA\\Richdocuments\\Controller\\DocumentController"],"index"]},{"file":"/srv/www/htdocs/nextcloud/lib/private/AppFramework/App.php","line":183,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[["OCA\\Richdocuments\\Controller\\DocumentController"],"index"]},{"file":"/srv/www/htdocs/nextcloud/lib/private/Route/Router.php","line":315,"function":"main","class":"OC\\AppFramework\\App","type":"::","args":["OCA\\Richdocuments\\Controller\\DocumentController","index",["OC\\AppFramework\\DependencyInjection\\DIContainer"],["richdocuments.document.index"]]},{"file":"/srv/www/htdocs/nextcloud/lib/base.php","line":1056,"function":"match","class":"OC\\Route\\Router","type":"->","args":["/apps/richdocuments/index"]},{"file":"/srv/www/htdocs/nextcloud/index.php","line":36,"function":"handleRequest","class":"OC","type":"::","args":[]}],"File":"/srv/www/htdocs/nextcloud/apps/richdocuments/lib/TokenManager.php","Line":176},"CustomMessage":"--"},"id":"6449f7c2cfb64"}

Let me know if you need more.

[joshtrichards]

@rigg77 Do you Nextcloud logs look similar to @Vachha's when this happens?

[kesselb]

Found "Call to a member function getOwner() on null in file" in a logfile.

external storage and its auth mechanism: no
server side encryption is enabled: no

richdocuments/lib/TokenManager.php

Line 171 in 826b54f

$file = $rootFolder->getById($fileId)[0];

The situation that getById returns an empty array is not handled properly.
It could be that the file was just deleted meanwhile, or something different.

{
  "reqId": "",
  "level": 3,
  "time": "2024-04-29T17:43:06+02:00",
  "remoteAddr": "",
  "user": "",
  "app": "richdocuments",
  "method": "POST",
  "url": "/index.php/apps/richdocuments/wopi/files/fileId_instanceId?access_token=tokenTokenToken&access_token_ttl=0",
  "message": "Uncaught error: Call to a member function getOwner() on null in file '/var/www/nextcloud/apps/richdocuments/lib/TokenManager.php' line 174",
  "userAgent": "COOLWSD HTTP Agent 23.05.10.1",
  "version": "28.0.4.2",
  "exception": {
    "Exception": "Exception",
    "Message": "Call to a member function getOwner() on null in file '/var/www/nextcloud/apps/richdocuments/lib/TokenManager.php' line 174",
    "Code": 0,
    "Trace": [
      {
        "file": "/var/www/nextcloud/lib/private/AppFramework/App.php",
        "line": 184,
        "function": "dispatch",
        "class": "OC\\AppFramework\\Http\\Dispatcher",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/Route/Router.php",
        "line": 315,
        "function": "main",
        "class": "OC\\AppFramework\\App",
        "type": "::"
      },
      {
        "file": "/var/www/nextcloud/lib/base.php",
        "line": 1069,
        "function": "match",
        "class": "OC\\Route\\Router",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/index.php",
        "line": 39,
        "function": "handleRequest",
        "class": "OC",
        "type": "::"
      }
    ],
    "File": "/var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php",
    "Line": 169,
    "Previous": {
      "Exception": "Error",
      "Message": "Call to a member function getOwner() on null",
      "Code": 0,
      "Trace": [
        {
          "file": "/var/www/nextcloud/apps/richdocuments/lib/Controller/WopiController.php",
          "line": 703,
          "function": "generateWopiToken",
          "class": "OCA\\Richdocuments\\TokenManager",
          "type": "->"
        },
        {
          "file": "/var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php",
          "line": 230,
          "function": "postFile",
          "class": "OCA\\Richdocuments\\Controller\\WopiController",
          "type": "->"
        },
        {
          "file": "/var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php",
          "line": 137,
          "function": "executeController",
          "class": "OC\\AppFramework\\Http\\Dispatcher",
          "type": "->"
        },
        {
          "file": "/var/www/nextcloud/lib/private/AppFramework/App.php",
          "line": 184,
          "function": "dispatch",
          "class": "OC\\AppFramework\\Http\\Dispatcher",
          "type": "->"
        },
        {
          "file": "/var/www/nextcloud/lib/private/Route/Router.php",
          "line": 315,
          "function": "main",
          "class": "OC\\AppFramework\\App",
          "type": "::"
        },
        {
          "file": "/var/www/nextcloud/lib/base.php",
          "line": 1069,
          "function": "match",
          "class": "OC\\Route\\Router",
          "type": "->"
        },
        {
          "file": "/var/www/nextcloud/index.php",
          "line": 39,
          "function": "handleRequest",
          "class": "OC",
          "type": "::"
        }
      ],
      "File": "/var/www/nextcloud/apps/richdocuments/lib/TokenManager.php",
      "Line": 174
    },
    "message": "Uncaught error: Call to a member function getOwner() on null in file '/var/www/nextcloud/apps/richdocuments/lib/TokenManager.php' line 174",
    "exception": {},
    "CustomMessage": "Uncaught error: Call to a member function getOwner() on null in file '/var/www/nextcloud/apps/richdocuments/lib/TokenManager.php' line 174"
  }
}

[joshtrichards]

Some relevant improvements were made in #3820 (and to some extent #4567).