fix: allow document creation only for users that can edit

[tanyaka]

Summary

This fix assures files creation from templates is not possible for users with read-only permissions.
Users with read-only permissions should not have option to create new document from diagram, document, presentation or spreadsheet template, see attached screenshot.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Documentation (manuals or wiki) has been updated or is not required

[tanyaka]

[juliusknorr]

/backport to stable31

[juliusknorr]

/backport to stable30

[juliusknorr]

/backport to stable29

[elzody]

I can't reproduce the issue here, can you quickly remind me what to do to reproduce this issue?

[tanyaka]

I can't reproduce the issue here, can you quickly remind me what to do to reproduce this issue?

We have found out this issue while working with collabora read-only. Here the user should not be able to edit the documents, but the current state is, that he can create and edit them.

[elzody]

I was able to reproduce and see what you mean now. However, in order to get the tests passing, you will need to rebase onto the latest main branch of richdocuments.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[printminion-co]

@juliusknorr will it be merged into master?

[backportbot]

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/4807/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick deab95d3

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/4807/stable29

Error: Failed to check for changes with origin/stable29: No changes found in backport branch

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.