[stable30] fix: for shares allow document creation only for users that ca…

[tanyaka]

Summary

This fix assures files creation from templates in public share is not possible for users with read-only permissions.
Users with read-only permissions should not have option to create new document from diagram, document, presentation or spreadsheet template, see attached screenshot.

This is a fix for nextcloud v30.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Documentation (manuals or wiki) has been updated or is not required
  

[elzody]

If this is a fix for Nextcloud v30 only, we would need to change the base branch from main to stable30 and then you would need to rebase onto stable30 and force push from your local branch. Or do I misunderstand?

[tanyaka]

If this is a fix for Nextcloud v30 only, we would need to change the base branch from main to stable30 and then you would need to rebase onto stable30 and force push from your local branch. Or do I misunderstand?

My bad, this is probably also a fix for v29, it's just not for v31, this file is not a part of v31 any more.

Edited: discussed with artonge, clarified.

[artonge]

git reset --hard HEAD~600
git rebase origin/stable30
git cherry-pick 14f78c1fde1d7879250092f93b5bd9306c8b6465

[artonge]

/backport to stable29

[elzody]

Seems fine to me now, thanks for the rebase. The failing Cypress tests are unrelated to this pull request, and have already been fixed, so this can safely be merged.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)