fix: undefined share for preview#4866
Merged
Merged
Conversation
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Productivity team
blizzz
reviewed
Jun 23, 2025
elzody
force-pushed
the
fix/undefined-share-previews
branch
from
f936f1c to
b3d697b
Compare
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
elzody
force-pushed
the
fix/undefined-share-previews
branch
from
b3d697b to
bcfe2c0
Compare
elzody
moved this from 🧭 Planning evaluation (don't pick)
to 👀 In review
in 📝 Productivity team
Collaborator
Author
|
/backport to stable31 |
Collaborator
Author
|
/backport to stable30 |
Collaborator
Author
|
The Cypress failures are unrelated. Still haven't had the chance to track down this crypto UUID stuff. |
blizzz
approved these changes
Jun 26, 2025
github-project-automation
Bot
moved this from 👀 In review
to ☑️ Done
in 📝 Productivity team
This was referenced Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevents
$sharebeingundefinedand causing an error in the logs. If we cannot compute$sharefor some reason, we simply passnullto thePermissionManager::shouldWatermark()method and it will handle the rest.Checklist