feat: use filetype icon as favicon #5234
Merged
+46
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Knorr <jus@bitgrid.net>
juliusknorr
requested review from
emberfiend,
marcoambrosini and
pedropintosilva
juliusknorr
added
enhancement
Member
Author
|
The missing icon in the collabora UI seems an issue on latest CODE |
jancborchardt
approved these changes
Dec 16, 2025
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Yeah @juliusknorr this looks super nice and is probably easier to recognize like this as opposed to if we would do the coloring the other way around. Cool! :)
marcoambrosini
approved these changes
Dec 18, 2025
github-project-automation
bot
moved this from 🏗️ At engineering
to 🎉 Done
in 🖍 Design team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @jancborchardt and @pedropintosilva
@jancborchardt I think the existing icons work very well, but we can still change to plain background color and white icons if you think that is better.