fix(test): stabilize save as test #5312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Office team
elzody
moved this from 🧭 Planning evaluation (don't pick)
to 👀 In review
in 📝 Office team
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
3 tasks
juliusknorr
approved these changes
Jan 30, 2026
Member
|
/backport to stable33 |
Member
|
/backport to stable32 |
Member
|
/backport to stable31 |
2 tasks
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reworked the
waitForPostMessagecustom Cypress command a bit to properly check for expected post message values. This should stabilize the "save as" test inintegration.spec.jssince it should now wait for theAction_Save_Respfrom Collabora confirming that the file was saved before trying to open it in the file list.Additionally, I have attempted to refactor the
waitForPostMessagecustom Cypress command to make it work properly. In the past, it did not compare the expected post message values to the actual values correctly. It also only took the first post message with the expected message ID, ignoring the rest. In fact, it only took the first matching post message, ignored the rest, and did not compare the values. Hopefully now it does, so we can use it to wait until the full expected post message is received, and error if it does not come.Checklist