Skip to content

fix(wopi): rate limit wopi endpoints#5606

Merged
elzody merged 1 commit into
mainfrom
fix/brute-force-version-history
Apr 30, 2026
Merged

fix(wopi): rate limit wopi endpoints#5606
elzody merged 1 commit into
mainfrom
fix/brute-force-version-history

Conversation

@elzody
Copy link
Copy Markdown
Collaborator

@elzody elzody commented Apr 29, 2026

The intention is to prevent someone editing with a guest token from abusing the checkFileInfo and getFile endpoints via rate limiting. The rate limiting is implemented in a service that handles it on a per-token basis. Additionally, guest users should not be able to request previous versions of a file since they do not have access to version history in the UI, so those requests are blocked.

@elzody elzody requested review from emberfiend and rikled April 29, 2026 21:05
@elzody elzody self-assigned this Apr 29, 2026
@elzody elzody requested a review from juliusknorr as a code owner April 29, 2026 21:05
@elzody elzody added the 3. to review Ready to be reviewed label Apr 29, 2026
@elzody
Copy link
Copy Markdown
Collaborator Author

elzody commented Apr 29, 2026

/backport to stable33 please

@elzody
Copy link
Copy Markdown
Collaborator Author

elzody commented Apr 29, 2026

/backport to stable32

@elzody elzody force-pushed the fix/brute-force-version-history branch from 44122a6 to 2afa1d0 Compare April 30, 2026 20:34
@elzody elzody changed the title fix(wopi): rate limit anon endpoints fix(wopi): rate limit wopi endpoints Apr 30, 2026
Uses a new rate limiter service to rate
limit certain WOPI endpoints via the
WOPI token. This attempts to prevent
abuse when a token tries to spam
requests.

Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
@elzody elzody force-pushed the fix/brute-force-version-history branch from 2afa1d0 to c5a9010 Compare April 30, 2026 21:06
@elzody elzody merged commit 59c2976 into main Apr 30, 2026
79 checks passed
@elzody elzody deleted the fix/brute-force-version-history branch April 30, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants