test(wopi): add coverage for locking operations#5627
Open
joshtrichards wants to merge 13 commits intomainfrom
Open
test(wopi): add coverage for locking operations#5627joshtrichards wants to merge 13 commits intomainfrom
joshtrichards wants to merge 13 commits intomainfrom
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
TBD whether to keep this or make it an alternate test path. Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
…Lock Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
…ng implementation as-is Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
changed the title
joshtrichards
added
3. to review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add WOPI test coverage for file locking behavior.
This PR adds support for exercising the following WOPI override flows in tests:
LOCKUNLOCKREFRESH_LOCKGET_LOCKIt also enables the
files_lockapp when running the WOPI integration feature suite so the lock-related scenarios can execute in CI.May be making some changes in this area. Figured adding coverage of pre-change code was wise. :-)
Notes
WopiControllerimplementation ignores the client-providedX-WOPI-Lockvalue for lock/unlock handling.GET_LOCKis included in the test context, but the current controller implementation does not yet return lock state to the client, so that scenario is not fully asserted yet.Checklist