fix(richdocuments): gate conversion with SecureViewService check#5635
Open
fix(richdocuments): gate conversion with SecureViewService check#5635
Conversation
Server-side conversion bypassed the Secure View / watermark restriction that the viewer enforces, allowing a user with view-only secure access to download a clean copy via the conversion API. Reuse SecureViewService (same logic the viewer uses) to deny conversion for files that should be secured. Handle the documented NotFoundException so a cache miss surfaces as a clear, translated error instead of a 500. Signed-off-by: Christoph Schaefer <christoph.schaefer@nextcloud.com>
elzody
reviewed
May 7, 2026
| try { | ||
| $secured = $this->secureViewService->shouldSecure( | ||
| $file->getInternalPath(), | ||
| $file->getStorage(), |
Collaborator
There was a problem hiding this comment.
Your change succeeds in blocking the conversion, but the error message given in the log is not the same. Looks like passing false to shouldSecure() allows it to take the correct branch, else you get a ForbiddenException:
Suggested change
| $file->getStorage(), | |
| $file->getStorage(), | |
| false, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server-side conversion bypassed the Secure View / watermark restriction that the viewer enforces, allowing a user with view-only secure access to download a clean copy via the conversion API. Reuse SecureViewService (same logic the viewer uses) to deny conversion for files that should be secured. Handle the documented NotFoundException so a cache miss surfaces as a clear, translated error instead of a 500.
Summary
TODO
apps/files/src/actions/convertAction.tsChecklist