Office Overview Part 3/5 - List view, view toggle and grid preference#5680
Merged
Conversation
Adds PUT /apps/richdocuments/settings/overview/grid_view endpoint to persist the overview view mode per user. OverviewController injects the saved preference as initial state so the frontend reads it on mount. Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
List view is now the default. A toggle in the toolbar switches between list and grid. List rows use NcListItem with mtime subname and a star indicator for favourites. The chosen mode persists via the new settings/overview/grid_view endpoint. Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
…le toggle, a11y fixes
- Center search bar; move view toggle into a files section header alongside
a "Recent {category}" h2 heading
- Toggle is now a single button switching icon based on current mode
- TemplateSection gets a subtle background (--color-background-hover) and
uses h2 + aria-labelledby for correct heading hierarchy
- FileCard changed from div to button for keyboard accessibility;
adds focus-visible outline
Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
Blank card was taller than template cards because min-height and padding-bottom combined. Replaced flex centering with absolute positioning for the icon so height is driven by padding-bottom alone. Template preview URLs were null from the API despite hasPreview: true. Generate from fileid using /core/preview (mirrors TemplatePreview.vue). File grid preview URLs now include etag version param and mimeFallback=1 so broken previews degrade to MIME icons rather than broken img elements. Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
Guard setOverviewGridView() against a null userId by returning 401 rather than writing to an empty-string uid. Mirror the same null guard in OverviewController::index() when reading the stored grid-view pref. Also rename the initial state key from 'config' to 'overview_config' to avoid colliding with any existing config state provided by other parts of the app. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
…meFallback param Replace the ratio-based padding-bottom trick in TemplateSection with a fixed 2/3 aspect-ratio so all categories (docs, sheets, presentations) render at the same height. Switch .template-card__preview to flex centering, removing the now-redundant absolute-position rule on the blank card icon. Add an @error handler that sets failedPreviews[fileid] so a broken image falls back to the file-type icon without a broken-image glitch. Use template.previewUrl when the API provides it, otherwise derive the URL from the fileid. In OfficeOverview, fix the preview URL to use mimeFallback=true (boolean string) instead of mimeFallback=1, and update the loadState key to match the renamed initial state ('overview_config'). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
moodyjmz
changed the title
Base automatically changed from
feat/overview-pr3-template-section
to
feat/office-overview-v2
May 20, 2026 16:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3 of 5 — see #5678 for the full series. Merge all PRs into
feat/office-overview-v2in order.NcListItem; grid/list toggle button persisted per userUserConfiginitial statemimeFallbackfixes