fix(SaveAs): improve filename validation, fix cant-empty-field bug, prefill path where available#5689
Open
emberfiend wants to merge 1 commit into
Open
fix(SaveAs): improve filename validation, fix cant-empty-field bug, prefill path where available#5689emberfiend wants to merge 1 commit into
emberfiend wants to merge 1 commit into
Conversation
…refill path where available Signed-off-by: Andrew Backhouse <andrew.backhouse@nextcloud.com>
Member
Member
joshtrichards
left a comment
joshtrichards
left a comment
There was a problem hiding this comment.
Cypress tests will need to be adjusted to accomodate / cover.
juliusknorr
reviewed
May 26, 2026
| }, | ||
| }, | ||
| isValidName() { | ||
| const value = this.newFileName.trim() |
Member
There was a problem hiding this comment.
Should also validate against https://github.com/nextcloud-libraries/nextcloud-files/blob/main/lib/utils/filename-validation.ts#L120 but fine to get this in as it fixes the original bug
juliusknorr
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
improve filename validation: some basic sanity checks on file names, pretty permissive so shouldn't annoy anyone
fix cant-empty-field bug: switched unedited flag to null so that emptying the field doesn't cause it to be regenerated
prefill path where available: allows anonymous-browser direct editing endpoint sessions to see the full file path
Checklist