OC dialog confirm improvements

[nickvergessen]

The current "Leaving call" modal could be better:

Ref nextcloud/spreed#3144 by @jancborchardt

• The icon is not needed, it just makes the text strangely aligned.
• Allow custom Yes/No button texts and "alert" instead of primary color, e.g. in Talk:
  • "No" button should be "Stay in call".
  • "Yes" button should be "Leave call" and not primary colored but red, as it is destructive.

[gary-kim]

I added OC.dialogs.confirmDestructive in #17785 and it sounds like that's pretty much what you're looking for.

It looks like this:


You can also configure what the cancel button says.

Posted a diff that uses OC.dialogs.confirmDestructive at nextcloud/spreed#3144 (comment)

[Dennis1993]

We should switch position of the buttons. Cancel to the right and the leave button to the left. That’s the default position and here is it wrong 🙂

[jancborchardt]

@gary-kim aaaawesome, as usual! :)

---

We should switch position of the buttons. Cancel to the right and the leave button to the left. That’s the default position and here is it wrong slightly_smiling_face

@Dennis1993 the primary action is always on the right, as in the majority of systems. (Given it’s a Left-to-Right language.)

[gary-kim]

Closing as the requested enhancements were already implemented.

[nickvergessen]

Yeah, thanks a lot fo rthe pointer @gary-kim