Sort completed tasks last in unified search

[raimund-schluessler]

How to support this request?

• Please use the 👍 reaction to show that you are also in favor of this feature - we are using this information to decide which features to include in upcoming Nextcloud versions.
• Please don't comment if you have no relevant information to add

---

It would be good to show completed tasks after uncompleted tasks in the unified search results. At the moment all tasks are shown indepentent of their completed state. Hence, although uncompleted tasks are certainly more important, they are sometimes only shown after clicking "show more results".

@georgehrke

[skjnldsv]

server/apps/dav/lib/Search/TasksSearchProvider.php

Lines 90 to 131 in d9015a8

	public function search(IUser $user,
	ISearchQuery $query): SearchResult {
	if (!$this->appManager->isEnabledForUser('tasks', $user)) {
	return SearchResult::complete($this->getName(), []);
	}
	$principalUri = 'principals/users/' . $user->getUID();
	$calendarsById = $this->getSortedCalendars($principalUri);
	$subscriptionsById = $this->getSortedSubscriptions($principalUri);
	$searchResults = $this->backend->searchPrincipalUri(
	$principalUri,
	$query->getTerm(),
	[self::$componentType],
	self::$searchProperties,
	self::$searchParameters,
	[
	'limit' => $query->getLimit(),
	'offset' => $query->getCursor(),
	]
	);
	$formattedResults = \array_map(function (array $taskRow) use ($calendarsById, $subscriptionsById):SearchResultEntry {
	$component = $this->getPrimaryComponent($taskRow['calendardata'], self::$componentType);
	$title = (string)($component->SUMMARY ?? $this->l10n->t('Untitled task'));
	$subline = $this->generateSubline($component);
	if ($taskRow['calendartype'] === CalDavBackend::CALENDAR_TYPE_CALENDAR) {
	$calendar = $calendarsById[$taskRow['calendarid']];
	} else {
	$calendar = $subscriptionsById[$taskRow['calendarid']];
	}
	$resourceUrl = $this->getDeepLinkToTasksApp($calendar['uri'], $taskRow['uri']);
	return new SearchResultEntry('', $title, $subline, $resourceUrl, 'icon-checkmark', false);
	}, $searchResults);
	return SearchResult::paginated(
	$this->getName(),
	$formattedResults,
	$query->getCursor() + count($formattedResults)
	);
	}

[ruedigerkupper]

Exactly the same holds true for already past calendar events. Future events are more important than past events, but past events are displayed first.

[szaimen]

Hi, please update to 24.0.9 or better 25.0.3 and report back if it fixes the issue. Thank you!

My goal is to add a label like e.g. 25-feedback to this ticket of an up-to-date major Nextcloud version where the bug could be reproduced. However this is not going to work without your help. So thanks for all your effort!

If you don't manage to reproduce the issue in time and the issue gets closed but you can reproduce the issue afterwards, feel free to create a new bug report with up-to-date information by following this link: https://github.com/nextcloud/server/issues/new?assignees=&labels=bug%2C0.+Needs+triage&template=BUG_REPORT.yml&title=%5BBug%5D%3A+

[raimund-schluessler]

The issue persists with 25.0.4. See here, the completed task is shown first: