Group deletion should delete shares

[kinimodmeyer]

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

Steps to reproduce

1. create a folder "test"
2. create a group "test"
3. share folder "test" with group "test"
4. delete group test

Expected behaviour

delete shares of group if group get deleted.
if later same group name get created again (maybe with other members) it will automatically have all the shares from the past
(this is also a "security" topic)

Server configuration

Nextcloud version: 21.0.1

[solracsf]

if later same group name get created again (maybe with other members) it will automatically have all the shares from the past
(this is also a "security" topic)

Have you reproduced this?

[szaimen]

cc @nextcloud/security

[nickvergessen]

Should listen to one of those events and clear all shares, yeah:

server/lib/private/Group/Group.php

Lines 361 to 366 in 215aef3

	if ($result) {
	$this->dispatcher->dispatch(IGroup::class . '::postDelete', new GenericEvent($this));
	if ($this->emitter) {
	$this->emitter->emit('\OC\Group', 'postDelete', [$this]);
	}
	}

[szaimen]

Hi, please update to 24.0.9 or better 25.0.3 and report back if it fixes the issue. Thank you!

My goal is to add a label like e.g. 25-feedback to this ticket of an up-to-date major Nextcloud version where the bug could be reproduced. However this is not going to work without your help. So thanks for all your effort!

If you don't manage to reproduce the issue in time and the issue gets closed but you can reproduce the issue afterwards, feel free to create a new bug report with up-to-date information by following this link: https://github.com/nextcloud/server/issues/new?assignees=&labels=bug%2C0.+Needs+triage&template=BUG_REPORT.yml&title=%5BBug%5D%3A+