Skip to content

Sharing sidebar [design review call] #51307

@marcoambrosini

Description

@marcoambrosini

Sidebar sharing design review

28.01.2025

Overall

  • Internal link in the select component (in issue already)
  • "Create public link" should be a (secondary) button
    • Clicking on button creates the share link with the button below
  • More vertical whitespace in the heading
  • Remove horizontal line and add more whitespace between sections (to do and compare with current)
  • Normal "i" button
  • Add documentation links inside info
  • What is additional shares?
  • Others w access and Additional shares should be hidden if empty
  • Incoming share summary "Shared with you by Marco Ambrosini" should wrap to the next line if too long
    • If in a Talk conversation use a user bubble "Shared with you and [ 🖌️ Design team ] by Marco Ambrosini"
  • If disabled permission for incoming share not readable for contrast
  • Checkmark when link is copied
    • There seems to be 2? Should be one
    • Add a short animation from copy icon to checkmark icon to make it clearer
  • Copy icon height is more than width? Currently 42px, needs to be 34px
  • External link dropdown placeholder "federated cloud id" --> "Federated Cloud ID"
  • Scrollbar is present? shouldn't be scrollable
  • Customize page
    • first item should be "Editing share link [title of share link]"
    • Clicking on ... menu > custom permissions shows custom permissions even if permissions are view only
    • Remove "advanced settings" toggle and expand settings by default
  • "View only" button text should be left aligned with the text above --> override internal padding
  • Expiration date issue [Bug]: Default link share expiration date not visible #50495

Related resources and other things

  • Adjust heading to match the other headings
  • add info box next to heading with explanation
  • Add heading + for team folders

Metadata

Metadata

Labels

Projects

Status

🏗️ At engineering

Status

Triaged

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions