Skip to content

Conversation

@praveenraonp
Copy link
Contributor

Modified the theming error message grammar , this fix is related to Issue #1107

@mention-bot
Copy link

@iamfool, thanks for your PR! By analyzing the annotation information on this pull request, we identified @blizzz, @juliushaertl and @LukasReschke to be potential reviewers

@rullzer
Copy link
Member

rullzer commented Aug 29, 2016

Thanks!

It seems we have very strict unit tests here: https://github.com/nextcloud/server/blob/master/apps/theming/tests/Settings/AdminTest.php#L115

Could you update that one as well so the tests pass :)

@praveenraonp
Copy link
Contributor Author

praveenraonp commented Aug 29, 2016

@rullzer yes I have made the changes , thanks for guiding me through :)

This is my first contribution to open source community. I know this is a extremely simple fix but feeling very excited :D

@rullzer
Copy link
Member

rullzer commented Aug 29, 2016

👍

You have to start out small. Lets hope it is the first for many to come 😄
Feel free to join our irc channel #nextcloud-dev on freenode or join the forums

@LukasReschke
Copy link
Member

Thanks a lot for your contribution, @iamfool 🚀 🎉 🎈 👍

@LukasReschke LukasReschke merged commit 4005e58 into nextcloud:master Aug 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants