Add option to set overwrite.cli.url for occ install#11602
Add option to set overwrite.cli.url for occ install#11602
Conversation
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
|
Is really the option needed or can't we just fix the breaking statement? Because I would avoid to put more options in the install command. Alternative way is to create a file <?php
$CONFIG = [
'overwrite.cli.url' => 'https://cloud.example.org',
];This file will then be merge in the config by default and will overwrite the one in config.php. |
For an automated setup i guess there is no huge difference (appending another option vs. prepare config.php). I took the issue because of https://github.com/nextcloud/server/labels/Hacktoberfest 🙈 |
It's not about admins, but about us. Because we then need to maintain multiple ways of doing it. 😉 |
Fine for me 👍 |
But the general fix in here is still nice to have. Or did it only fix the issue when the option was provided? |
|
The issue is only fixed when option provided. server/lib/private/AppFramework/Http/Request.php Lines 816 to 822 in c0a283f localhost is coming from this place because there is no way to detect url when using occ.
|
Set overwrite.cli.url for occ maintenance:install
Close #6313