Exclude older PHP versions from .travis.yml #1198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LukasReschke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @nickvergessen and @MorrisJobke to be potential reviewers |
Member
|
LGTM cuts exec times of tests in half https://travis-ci.org/nextcloud/server/builds/156264640 vs https://travis-ci.org/nextcloud/server/builds/156210837 |
Member
Author
|
Awesome, Travis execution is also much faster. Before: 20 minutes 50 secs 🚀 |
Member
|
👍 |
| // Show warning if a PHP version below 5.6.0 is used, this has to happen here | ||
| // because base.php will already use 5.6 syntax. | ||
| if (version_compare(PHP_VERSION, '5.6.0') === -1) { | ||
| echo 'This version of Nextcloud requires at least PHP 5.6.0<br/>'; |
Member
There was a problem hiding this comment.
The name change is already backported?
Member
Author
There was a problem hiding this comment.
v9.0.51 fixed that: https://github.com/nextcloud/server/blob/v9.0.51/index.php#L30
=> 8abf6e0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @karlitschek @MorrisJobke @nickvergessen