extend storage api to allow directly writing a stream to storage #12072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
approved these changes
Oct 28, 2018
Member
rullzer
left a comment
rullzer
left a comment
There was a problem hiding this comment.
I'll give it a spin tomorrow.
But in general looks good. And awesome stuff 🚀
Member
😉 |
Member
|
Works like a charm here :) Only CI is having hiccups on the encryptedUpload tests no idea why |
MorrisJobke
approved these changes
Oct 30, 2018
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
Code looks good and existing workflows still work fine 👍
MorrisJobke
added
4. to release
MorrisJobke
added
2. developing
Member
|
Seems encryption is still not happy |
icewind1991
force-pushed
the
writestream
branch
3 times, most recently
from
bfa0c88 to
ab0db53
Compare
this removes the need for temporary storages with some external storage backends. The new method is added to a separate interface to maintain compatibility with storage backends implementing the storage interface directly (without inheriting common) Currently the interface is implemented for objectstorage based storages and local storage and used by webdav uploads Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
writestream
branch
from
2f92f90 to
9b3cc72
Compare
Member
Author
|
I think the remaining failure is unrelated |
icewind1991
added
3. to review
rullzer
approved these changes
Nov 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this removes the need for temporary storages with some external storage backends.
The new method is added to a separate interface to maintain compatibility with
storage backends implementing the storage interface directly (without inheriting common)
Currently the interface is implemented for objectstorage based storages and local storage
and used by webdav uploads
This is a change I've been wanting to do forever but never got around to before.