Add Codesniffer to detect unused use-statements

[nickvergessen]

(more to come)

ToDo

• Unused use statements:
  • Fix instanceof $a instanceof $b;
  • Fix closures function($u, IU $e, $d, IUser $i){};
  • Fix type-comments /* @var IQueryBuilder $qb */

Steps

cd build/codesniffer
composer install
./vendor/bin/phpcs -s -p --extensions=php --standard=nextcloud-unused.xml ../../apps/twofactor_backupcodes/

[mention-bot]

@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @bantu, @DeepDiver1975 and @icewind1991 to be potential reviewers

[nickvergessen]

Should be ready for review, is not yet executed, because a lot of things need fixing atm 🙈

[ChristophWurst]

should we adjust this license header?

[nickvergessen]

Right, I just c+p the file. But we are thinking about putting it into another project, then we could composer it. Until then I think we should just keep the copright+license, if that is okay @schiessle

[ChristophWurst]

at least this line should be changed. Currently it's leading to a non-existing file

[rullzer]

Ah yes we need the content of that file here then ;)

[nickvergessen]

Yeah, let's delay until it is split by phpBB into a decent package.

[bantu]

I agree this should be split from phpBB. Cheers

[rullzer]

Awesome stuff @nickvergessen
Besides the licence thingy 👍

[MorrisJobke]

@nickvergessen Could you have a look at this? Shouldn't be that hard to get this into shape

[nickvergessen]

I will continue this, once it was split into a separate composer package by upstream.

[MorrisJobke]

I will continue this, once it was split into a separate composer package by upstream.

Any news here?

[nickvergessen]

Still on my todo, will close for now