Better comments in activity sidebar #1519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LukasReschke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @nickvergessen, @jancborchardt and @MorrisJobke to be potential reviewers |
| @@ -0,0 +1,59 @@ | |||
| /* | |||
| * @author Joas Schilling <nickvergessen@owncloud.com> | |||
Member
|
Also requires a patch in the activity app, will have a look at that. |
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
better-comments-in-activity-sidebar
branch
from
4a5dba7 to
43265be
Compare
Member
|
Requires nextcloud/activity#49 to have a visual impact (multi-line and long comments are trimmed to 3 lines and can be expended with a click) |
Member
|
👍, second review @rullzer ? |
Current coverage is 30.61% (diff: 0.00%)@@ master #1519 diff @@
==========================================
Files 1081 1081
Lines 60041 60037 -4
Methods 6808 6808
Messages 0 0
Branches 0 0
==========================================
Hits 18378 18378
+ Misses 41663 41659 -4
Partials 0 0
|
Member
|
Tested and works 👍 |
MorrisJobke
approved these changes
Oct 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstreaming of owncloud/core#24275
cc @nickvergessen as you wrote most of it