Use a php class for the definitions to avoid loading problems #2052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
bug
3. to review
|
@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @LukasReschke and @rullzer to be potential reviewers. |
Member
|
Fine by me. LGTM |
Member
|
Ah conflicts!!!! |
Member
Author
|
Yeah share by mail was merged, all okay will update tomorrow |
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
ros-definitions-as-php-class
branch
from
9755186 to
706b5c3
Compare
Member
Author
|
Rebased |
Current coverage is 57.77% (diff: 100%)@@ master #2052 diff @@
==========================================
Files 1096 1097 +1
Lines 62915 62923 +8
Methods 7015 7016 +1
Messages 0 0
Branches 0 0
==========================================
+ Hits 36344 36352 +8
Misses 26571 26571
Partials 0 0
|
Signed-off-by: Joas Schilling <coding@schilljs.com>
LukasReschke
previously requested changes
Nov 9, 2016
Member
LukasReschke
left a comment
LukasReschke
left a comment
There was a problem hiding this comment.
Looks awesome! Two nitpicks, will just adjust them myself and push to this branch :)
🚀 👍
| * @return string[] | ||
| */ | ||
| protected function getRequiredParameters($type) { | ||
| protected function getRequiredParameters($type, $definition) { |
| return $this->definitions[$type]; | ||
| } | ||
|
|
||
| throw new InvalidObjectExeption('Object type is undefined'); |
Member
There was a problem hiding this comment.
Missing test. Will add myself :)
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Member
|
LGTM |
Member
Author
|
👍 for lukas commit |
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid the "Can not load file ..../definitions.json" we see on drone from time to time.
cc @MorrisJobke @rullzer @LukasReschke