Skip to content

Conversation

@nickvergessen
Copy link
Member

@LukasReschke this fixes the broken search I saw for you at the stuttgart meetup

Signed-off-by: Joas Schilling <coding@schilljs.com>
@mention-bot
Copy link

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @PVince81 and @MorrisJobke to be potential reviewers.

@LukasReschke
Copy link
Member

Works 👍

@MorrisJobke
Copy link
Member

Steps:

  • open app management
  • go to disabled category
  • search:
    • before: 💥
    • afterwards: 🚀

Tested and works 👍

But JS tests fail 😢

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
Copy link
Member

rullzer commented Nov 13, 2016

Js test fixed.
But they do not cover the new code

@nickvergessen nickvergessen merged commit 4c6e9dc into master Nov 14, 2016
@nickvergessen nickvergessen deleted the fix-single-author-with-details branch November 14, 2016 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants