handle errors in apps while registering commands #2302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @butonic and @DeepDiver1975 to be potential reviewers. |
Member
|
👍 |
| * @param IRequest $request | ||
| */ | ||
| public function __construct(IConfig $config, EventDispatcherInterface $dispatcher, IRequest $request) { | ||
| public function __construct(IConfig $config, EventDispatcherInterface $dispatcher, IRequest $request, ILogger $logger) { |
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
register-command-error-handling
branch
from
4cb8530 to
65ace7c
Compare
LukasReschke
approved these changes
Nov 24, 2016
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't completely break the console just because a single app fucked up