Skip to content

Conversation

@LukasReschke
Copy link
Member

@LukasReschke LukasReschke commented Dec 21, 2016

@icewind1991 I tried to port the FTP external storage tests to Drone but they do fail. Any idea what is going wrong here?

@LukasReschke LukasReschke added the 1. to develop Accepted and waiting to be taken care of label Dec 21, 2016
@mention-bot
Copy link

@LukasReschke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MorrisJobke, @Xenopathic and @oparoz to be potential reviewers.

@codecov-io
Copy link

codecov-io commented Dec 21, 2016

Codecov Report

Merging #2806 into master will increase coverage by 0.01%.

@@            Coverage Diff             @@
##           master    #2806      +/-   ##
==========================================
+ Coverage   54.08%   54.09%   +0.01%     
==========================================
  Files        1304     1304              
  Lines       80542    80556      +14     
  Branches     1243     1243              
==========================================
+ Hits        43563    43580      +17     
+ Misses      36979    36976       -3
Impacted Files Coverage Δ
apps/files_external/lib/Lib/Storage/FTP.php 0% <ø> (ø)
lib/private/Files/Cache/Propagator.php 96.2% <ø> (+1.26%)
lib/private/Http/Client/Client.php 98.36% <ø> (+10.36%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60a8a1a...f0c3250. Read the comment docs.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@MorrisJobke
Copy link
Member

Rebased and fixed conflicts

@icewind1991
Copy link
Member

Might be time to finally replace the backend with a more tested and maintained one (https://github.com/icewind1991/files_external_ftp)

@MorrisJobke
Copy link
Member

Might be time to finally replace the backend with a more tested and maintained one (https://github.com/icewind1991/files_external_ftp)

Feel free to do so ;)

@LukasReschke
Copy link
Member Author

Closing this for now. Can be reopened later.

@LukasReschke LukasReschke deleted the add-tests-ftp-linux branch February 22, 2017 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1. to develop Accepted and waiting to be taken care of

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants