-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
[POC] Add tests ftp linux #2806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@LukasReschke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MorrisJobke, @Xenopathic and @oparoz to be potential reviewers. |
bf01e3c to
b852d97
Compare
Codecov Report@@ Coverage Diff @@
## master #2806 +/- ##
==========================================
+ Coverage 54.08% 54.09% +0.01%
==========================================
Files 1304 1304
Lines 80542 80556 +14
Branches 1243 1243
==========================================
+ Hits 43563 43580 +17
+ Misses 36979 36976 -3
Continue to review full report at Codecov.
|
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
b852d97 to
f0c3250
Compare
|
Rebased and fixed conflicts |
|
Might be time to finally replace the backend with a more tested and maintained one (https://github.com/icewind1991/files_external_ftp) |
Feel free to do so ;) |
|
Closing this for now. Can be reopened later. |
@icewind1991 I tried to port the FTP external storage tests to Drone but they do fail. Any idea what is going wrong here?