Fix gap by filter svg and empty search message overflow#3192
Fix gap by filter svg and empty search message overflow#3192MorrisJobke merged 2 commits intomasterfrom
Conversation
|
@eppfel, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jancborchardt, @ChristophWurst and @icewind1991 to be potential reviewers. |
|
How can I reproduce the old behaviour? |
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
Found the difference. It's a small gap at the top. With this fix the content is more on the top.
👍
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Please do it with css in css files, not in the templates.
:)
Signed-off-by: Felix A. Epp <work@felixepp.de>
eppfel
force-pushed
the
fix-app-settings-layout-minor
branch
from
d35f6f4 to
82bfe3b
Compare
eppfel
added
3. to review
|
Please review again! Anyone knows what's with the codecov/patch check? |
|
I added a class just to be more specific and clear :) |
Current coverage is 53.92% (diff: 0.00%)@@ master #3192 diff @@
==========================================
Files 1299 1299
Lines 80134 80350 +216
Methods 7909 7938 +29
Messages 0 0
Branches 1248 1248
==========================================
+ Hits 43227 43332 +105
- Misses 36907 37018 +111
Partials 0 0
|
it's there to check for the change in code coverage compared to what was there before. So it fails everytime the coverage is less than before 🙈 |
5 participants
The svg with the filter definition was using space, fixed with float.
With the change to flexbox the display:none of the .hidden class was overwritten.