Skip to content

Conversation

@MorrisJobke
Copy link
Member

@LukasReschke @icewind1991 Should we do this? Or could this expose potential sensitive data? I guess not, because we only show HintExceptions to the enduser.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@mention-bot
Copy link

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @LukasReschke and @nickvergessen to be potential reviewers.

@codecov-io
Copy link

Codecov Report

Merging #3939 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #3939      +/-   ##
============================================
- Coverage     54.22%   54.22%   -0.01%     
  Complexity    21133    21133              
============================================
  Files          1304     1304              
  Lines         80731    80731              
  Branches       1282     1282              
============================================
- Hits          43779    43778       -1     
- Misses        36952    36953       +1
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/View.php 85.86% <100%> (ø) 362 <0> (ø) ⬇️
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 528a903...fc57d4b. Read the comment docs.

Copy link
Member

@LukasReschke LukasReschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LukasReschke @icewind1991 Should we do this? Or could this expose potential sensitive data? I guess not, because we only show HintExceptions to the enduser.

We had cases in the past where somebody did a catch and then just showed all exceptions. I personally would prefer to do a log entry instead as well with the details.

@MorrisJobke
Copy link
Member Author

We had cases in the past where somebody did a catch and then just showed all exceptions. I personally would prefer to do a log entry instead as well with the details.

Okay - could you adjust this PR to log it and revert the exception message?

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@MorrisJobke
Copy link
Member Author

Changes look good 👍

@nickvergessen nickvergessen merged commit 85a5c24 into master Mar 20, 2017
@nickvergessen nickvergessen deleted the downstream-27159 branch March 20, 2017 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants