-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Fix malformed logging in exception #3939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
|
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @LukasReschke and @nickvergessen to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## master #3939 +/- ##
============================================
- Coverage 54.22% 54.22% -0.01%
Complexity 21133 21133
============================================
Files 1304 1304
Lines 80731 80731
Branches 1282 1282
============================================
- Hits 43779 43778 -1
- Misses 36952 36953 +1
Continue to review full report at Codecov.
|
LukasReschke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LukasReschke @icewind1991 Should we do this? Or could this expose potential sensitive data? I guess not, because we only show HintExceptions to the enduser.
We had cases in the past where somebody did a catch and then just showed all exceptions. I personally would prefer to do a log entry instead as well with the details.
Okay - could you adjust this PR to log it and revert the exception message? |
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
|
Changes look good 👍 |
@LukasReschke @icewind1991 Should we do this? Or could this expose potential sensitive data? I guess not, because we only show HintExceptions to the enduser.