Fix check for cache value in JSCombiner #4131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixes following log output, because there was empty string stored in the cache Invalid argument supplied for foreach() at lib/private/Template/JSCombiner.php#108 Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
requested review from
LukasReschke,
icewind1991,
nickvergessen and
rullzer
|
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer and @LukasReschke to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## master #4131 +/- ##
============================================
- Coverage 54.22% 54.22% -0.01%
- Complexity 21310 21311 +1
============================================
Files 1310 1310
Lines 81293 81295 +2
Branches 1285 1285
============================================
+ Hits 44078 44079 +1
- Misses 37215 37216 +1
Continue to review full report at Codecov.
|
rullzer
approved these changes
Mar 29, 2017
ChristophWurst
approved these changes
Apr 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stored in the cache