perf(frontend): lazy load the unified search modal #43400
Closed
perf(frontend): lazy load the unified search modal #43400
Conversation
st3iny
force-pushed
the
chore/perf/lazy-search
branch
from
e39bfba to
1435eab
Compare
st3iny
changed the title
ShGKme
reviewed
Feb 6, 2024
nfebe
reviewed
Feb 6, 2024
Contributor
nfebe
left a comment
nfebe
left a comment
There was a problem hiding this comment.
Test and it works, please address earlier comments.
susnux
reviewed
Feb 7, 2024
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
I would rather recommend not lazy load the unified search modal but show a modal with NcEmptyContent and loading spinner and just lazy load the modal content.
st3iny
force-pushed
the
chore/perf/lazy-search
branch
from
1435eab to
020b5e2
Compare
Member
Author
|
I implemented a loading spinner and added a screencast to the description. Note that I throttled my bandwidth during the recording to exaggerate the effect. It loads much faster on a regular connection. |
st3iny
force-pushed
the
chore/perf/lazy-search
branch
from
020b5e2 to
4c7974e
Compare
nfebe
approved these changes
Feb 7, 2024
Contributor
nfebe
left a comment
nfebe
left a comment
There was a problem hiding this comment.
Not tested, code looks okay
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
force-pushed
the
chore/perf/lazy-search
branch
from
4c7974e to
949044b
Compare
Member
Author
|
I'm closing this one as the benefit is too small.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Defer loading the unified search modal until it is first opened. Show a loading spinner while the modal is being loaded in the background.
(Bandwidth has been throttled during the recording to exaggerate the effect.)
Screencast_20240207_112434-1.mp4
Checklist