Fix link password toggle #4468
Merged
Fix link password toggle #4468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We took the wrong field from the share api response. So the password was never shown as set. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
|
@rullzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @blizzz, @schiessle and @icewind1991 to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## master #4468 +/- ##
============================================
+ Coverage 54.11% 54.11% +<.01%
Complexity 21679 21679
============================================
Files 1331 1331
Lines 83066 83066
Branches 1312 1312
============================================
+ Hits 44951 44952 +1
+ Misses 38115 38114 -1
|
icewind1991
approved these changes
Apr 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We took the wrong field from the share api response. So the password was
never shown as set.
To test:
Before: No password set shown
Now: Password set shown