Skip to content

Conversation

@MorrisJobke
Copy link
Member

Steps:

  • have calendar and contacts enabled
  • do an upgrade via occ upgrade (before just change the version in config.php to a smaller number to trigger an update)
  • before: both apps are disabled with output like "Disabled 3rd-party app: contacts"
  • after: they kept enabled

Verify that you run on PHP 7.0+

Background: before the CLI flag was forcefully setting this option to false, which has overwritten the logic in the Updater constructor:

if(version_compare(phpversion(), '7.0.0', '>=')) {

Discussed this already with @LukasReschke - in the web UI this works already fine.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Apr 27, 2017
@MorrisJobke MorrisJobke added this to the Nextcloud 12.0 milestone Apr 27, 2017
@mention-bot
Copy link

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @Gomez and @ringmaster to be potential reviewers.

@LukasReschke LukasReschke merged commit a809aa5 into master Apr 28, 2017
@LukasReschke LukasReschke deleted the do-not-disable-3rdparty-apps-on-cli-upgrade branch April 28, 2017 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants