Skip to content

Conversation

@MorrisJobke
Copy link
Member

  • moves all the small checks that basically only that a few seconds into one job
  • removes overhead of cloning it 6 times

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label May 2, 2017
@MorrisJobke MorrisJobke added this to the Nextcloud 12.0 milestone May 2, 2017
@mention-bot
Copy link

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @rullzer and @danxuliu to be potential reviewers.

@codecov
Copy link

codecov bot commented May 2, 2017

Codecov Report

Merging #4669 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4669      +/-   ##
============================================
- Coverage     54.29%   54.29%   -0.01%     
  Complexity    22093    22093              
============================================
  Files          1360     1360              
  Lines         84686    84686              
  Branches       1325     1325              
============================================
- Hits          45980    45979       -1     
- Misses        38706    38707       +1
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (ø)
lib/private/Security/CertificateManager.php 92.78% <0%> (-1.04%) 38% <0%> (ø)
lib/private/Server.php 93.51% <0%> (+0.14%) 120% <0%> (ø) ⬇️

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@MorrisJobke
Copy link
Member Author

CI only -> merge

@MorrisJobke MorrisJobke merged commit c079ca7 into master May 2, 2017
@MorrisJobke MorrisJobke deleted the checkers branch May 2, 2017 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants