Skip to content

Conversation

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented May 10, 2017

Uses first bucket of a multi bucket setup for the root FS

How to test

Install https://github.com/jubos/fake-s3 and start it:

sudo gem install fakes3
mkdir /tmp/s3
fakes3 -r /tmp/s3 -p 4567

Configure multibucket:

'objectstore_multibucket' => [
	'class' => 'OC\\Files\\ObjectStore\\S3',
	'arguments' => [
		'bucket' => 'abc',
		'num_buckets' => 64,
		'key' => '123',
		'secret' => 'abc',
		'hostname' => 'localhost',
		'port' => '4567',
		'use_ssl' => false,
		'use_path_style' => 'true',
	],
],

Check out that the data dir only holds the log file and no appdata_* folders.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added 3. to review Waiting for reviews bug high labels May 10, 2017
@MorrisJobke MorrisJobke added this to the Nextcloud 12.0 milestone May 10, 2017
@MorrisJobke MorrisJobke requested a review from rullzer May 10, 2017 18:24
@mention-bot
Copy link

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @LukasReschke and @Kondou-ger to be potential reviewers.

@MorrisJobke MorrisJobke requested a review from icewind1991 May 10, 2017 18:25
if (!isset($config['arguments']['bucket'])) {
$config['arguments']['bucket'] = '';
}
// put the root FS always in first bucket for multibucket configuration
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is basically a copy of initObjectStoreRootFS() only the 5 lines above this comment are added.

* followup to #3978 because with the proper setup of
  appdata we now are using the same data on all nodes

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
Copy link
Member Author

I also added the fix for #3978 (comment) as well here:

 Use distributed cache for SCSS dependencies as well
    
    * followup to #3978 because with the proper setup of
      appdata we now are using the same data on all nodes

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!
Tested with fakes3 and works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants