-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Setup root FS for multibucket object storage #4798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
|
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @LukasReschke and @Kondou-ger to be potential reviewers. |
| if (!isset($config['arguments']['bucket'])) { | ||
| $config['arguments']['bucket'] = ''; | ||
| } | ||
| // put the root FS always in first bucket for multibucket configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is basically a copy of initObjectStoreRootFS() only the 5 lines above this comment are added.
* followup to #3978 because with the proper setup of appdata we now are using the same data on all nodes Signed-off-by: Morris Jobke <hey@morrisjobke.de>
|
I also added the fix for #3978 (comment) as well here: |
rullzer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense!
Tested with fakes3 and works!
Uses first bucket of a multi bucket setup for the root FS
How to test
Install https://github.com/jubos/fake-s3 and start it:
Configure multibucket:
Check out that the data dir only holds the log file and no appdata_* folders.