Skip to content

refactor(base.php): First pass at some tidying #54469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
joshtrichards wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

refactor(base.php): First pass at some tidying #54469

joshtrichards wants to merge 7 commits into from

Conversation

@joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Aug 16, 2025 •
edited
Loading

  • Resolves: #

Summary

TODO

  • finish and test first half of init() refactoring
  • move init() to the top
  • finish other half of init() refactoring
  • misc:
    • confirm the OC_autoload comment that is currently near the top for applicability today

Follow-ups (?)

  • tbd

Checklist

@joshtrichards
refactor(base.php): First pass at some tidying
f81497b 
- Some comments
- Some delegation for readability
- Some formatting

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards
chore(base.php): Move init() to the top
8a16751 
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards
fix: fixup base.php
e495111 
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards
refactor: additional base::init() refactoring
8c906cc 
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards
fix: fixup location of $config initialization
83d9604 
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards
refactor(base): some more comment clean-up
5b0108f 
Signed-off-by: Josh <josh.t.richards@gmail.com>
@skjnldsv skjnldsv added enhancement 2. developing Work in progress ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Aug 19, 2025
@joshtrichards
chore: more base.php
1337b9c 
Signed-off-by: Josh <josh.t.richards@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

2. developing Work in progress enhancement ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joshtrichards @skjnldsv