fix(performance): move array_merge outside of loop

[miaulalala]

• Resolves: #
  Also some general cleanup and a try at caching if it is deemed useful.

TODO

• ...

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)
• Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
• Milestone added for target branch/version (ex: 32.x for stable32)

[miaulalala]

The caching is an experiment. I think it would make sense to cache the user data (and possibly also the groups) as long as there is no editing being done. An event listener could cache bust for any user related events. For large instances, caching the details may be useful.

Wdyt @Altahrim @skjnldsv ?

[skjnldsv]

Always up for more caching sure!
Not sure if you want more definitive one or just at the runtime level.

imho account data could easily be stored in redis as a middle and pulled from the db if not cached ?

[miaulalala]

imho account data could easily be stored in redis as a middle and pulled from the db if not cached ?

absolutely. Reasonable cache TTL plus busting on user events and we should have a working solution. I'll continue with my experimentation then 😉