Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Nov 26, 2025

Summary

So we do not have 3 locatations to look for PHP dependencies.

Checklist

@susnux susnux added 3. to review Waiting for reviews technical debt labels Nov 26, 2025
@susnux susnux force-pushed the chore/move-behat-to-vendor-bin branch 3 times, most recently from 5e71d01 to ab247d6 Compare November 26, 2025 15:34
@susnux susnux marked this pull request as ready for review November 26, 2025 18:15
@susnux susnux requested a review from a team as a code owner November 26, 2025 18:15
@susnux susnux requested review from come-nc, leftybournes, provokateurin, salmart-dev and yemkareems and removed request for a team November 26, 2025 18:15
@susnux susnux added this to the Nextcloud 33 milestone Nov 27, 2025
@susnux susnux force-pushed the chore/move-behat-to-vendor-bin branch from ab247d6 to cc3cfac Compare December 9, 2025 12:44
@susnux susnux requested a review from provokateurin December 9, 2025 12:45
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That already breaks because there is no /tests/acceptance folder.
I also do not understand what that should do:

  • clone server
  • install dependencies
  • remove everything ❓

So from the current state where tests/acceptance do not exist and it works it seems it will also work with this changes here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah for php 8.3 that one was removed:
https://github.com/nextcloud/docker-ci/blob/master/integration-php8.3/Dockerfile

but we should basically align this then.

but I once again got confused by our weird naming. it's not the continuous-integration-php8.3 but the continuous-integration-integration-php8.3 🙈
The only place that uses that is the server run intergration tests in docker, but yeah basically rebuilding that image will be broken, but then I don't care for the past.
We just should fix master for the latest php version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only place that uses that is the server run intergration tests in docker, but yeah basically rebuilding that image will be broken, but then I don't care for the past.

Shall we then just drop the image completely and just use the normal image in server?
Because we can do the same in the server script.

@susnux susnux force-pushed the chore/move-behat-to-vendor-bin branch from 782c7a0 to ee4133d Compare December 9, 2025 13:53
@susnux susnux requested a review from nickvergessen December 9, 2025 13:56
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only negative thing is that you need to install composer deps in server root, which makes lib/composer/* dirty again, but it's the same for psalm, cs and others so I guess we are used to it by now

So we do not have 3 locatations to look for PHP dependencies.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the chore/move-behat-to-vendor-bin branch from ee4133d to e0e2d0f Compare December 10, 2025 00:13
@susnux susnux merged commit 496404d into master Dec 10, 2025
208 of 212 checks passed
@susnux susnux deleted the chore/move-behat-to-vendor-bin branch December 10, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants