Skip to content

chore: Deprecate unused ISystemTagManagerFactory, DI is enough #57098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
provokateurin merged 1 commit into from
Dec 16, 2025
Merged

chore: Deprecate unused ISystemTagManagerFactory, DI is enough #57098

provokateurin merged 1 commit into from
Dec 16, 2025

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented Dec 15, 2025

Summary

This interface is useless and unused, it only passed requests through to DI.
Also it refers to IServerContainer which is deprecated already.

Checklist

@come-nc
chore: Deprecate unused ISystemTagManagerFactory, DI is enough
c8ce132 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added this to the Nextcloud 33 milestone Dec 15, 2025
@come-nc come-nc self-assigned this Dec 15, 2025
@come-nc come-nc requested a review from a team as a code owner December 15, 2025 16:30
@come-nc come-nc added the 3. to review Waiting for reviews label Dec 15, 2025
@come-nc come-nc requested review from ArtificialOwl, CarlSchwan, icewind1991 and yemkareems and removed request for a team December 15, 2025 16:30
@provokateurin provokateurin merged commit 5f6e6b3 into master Dec 16, 2025
202 of 207 checks passed
@provokateurin provokateurin deleted the fix/deprecate-ISystemTagManagerFactory branch December 16, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Altahrim Altahrim Altahrim approved these changes

@provokateurin provokateurin provokateurin approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems is a code owner automatically assigned from nextcloud/server-backend

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan CarlSchwan is a code owner automatically assigned from nextcloud/server-backend

Assignees

@come-nc come-nc

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

4 participants

@come-nc @Altahrim @provokateurin