Skip to content

Conversation

@joshtrichards
Copy link
Member

Summary

  • Check for presence of info.xml in app folder, not just the presence of an app folder (which could be empty/incomplete/etc)
  • Unify parameter names for the "appId" for all functions in the class

TODO

  • ...

Checklist

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added bug feature: apps management ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) feature: install and update labels Jan 1, 2026
@joshtrichards joshtrichards requested a review from come-nc January 1, 2026 16:45
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added the 3. to review Waiting for reviews label Jan 1, 2026
@joshtrichards joshtrichards marked this pull request as ready for review January 1, 2026 16:49
@joshtrichards joshtrichards requested a review from a team as a code owner January 1, 2026 16:49
@joshtrichards joshtrichards requested review from leftybournes, salmart-dev and yemkareems and removed request for a team January 1, 2026 16:49
@CarlSchwan CarlSchwan merged commit 1b12fd0 into master Jan 2, 2026
236 of 247 checks passed
@CarlSchwan CarlSchwan deleted the jtr/fix-installer-isDownloaded-robustness branch January 2, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug feature: apps management feature: install and update ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants